[Bug 784069] Add support for OMX_UseBuffer in gstomxvideodec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784069

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 354712:
 --> (https://bugzilla.gnome.org/review?bug=784069&attachment=354712)

::: omx/gstomxvideodec.c
@@ +841,3 @@
+          gst_buffer_map (buffer, &info, GST_MAP_WRITE);
+          images = g_list_append (images, info.data);
+              "Failed to allocated %d-th buffer of type %s, n_mem: %d", i,

The only guard is that gst-omx has a ref on the associated GstBuffer when
calling gst_omx_port_use_buffers. Same when playing, gst-omx has a ref on the
GstBuffer before to let the omx platform write into the data.
I have mimic what has been done for eglimage which is not mappable. Maybe here
I can make sure to keep the buffer mapped while gst_omx_port_use_buffers is
called and also when gst-omx calls gst_omx_port_release_buffer from
gst_omx_buffer_pool_release_buffer. And unmap when calling acquire.

For the other remark, indeed I can check that info.size >=
port->port_def.nBufferSize. And also check gst_buffer_map ret.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.