[Bug 753323] mpegts: add support for JPEG 2000 to mpegtsmux and tsdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753323

--- Comment #120 from Aaron Boxer <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #117)
> 
> 
> @@ +809,3 @@
> +    private_data->interlace = FALSE;    /* will be set later. TODO:
> interlace video mode doesn't work yet */
> +    private_data->den = 0;      /* will be set later */
> +    private_data->num = 0;      /* will be set later */
> 
> Is a fixed framerate required, or can it be 0/1 or 0/0?


Not sure if frame rate is fixed. What does 0/1 and 0/0 mean ?


> 
> @@ +812,3 @@
> +    private_data->max_bitrate = max_rate;
> +    private_data->Fic = 1;      /* TODO: get from caps */
> +    private_data->Fio = 0;      /* TODO: get from caps */
> 
> What is the meaning of these?

I am not sure what Fix and Fio mean, but since we don't support "interlaced",
it shouldn't matter at this stage.

> 
> @@ +842,3 @@
> +          color_spec = 3;
> +        } else {
> +          color_spec = 1;       /* RGB as default */
> 
> What is it that is these values mean? Color range, primaries, matrix, gamma
> transfer function, all at once? You might want to use
> gst_video_colorimetry_from_string() and then look specifically at the struct
> returned

I think the color spec indicates the colour space.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.