[Bug 753323] mpegts: add support for JPEG 2000 to mpegtsmux and tsdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753323

--- Comment #121 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Aaron Boxer from comment #118)

> Also, I am not sure how to handle the frame number issue - Milos had some
> problems with the frame number, but I am not clear on what they were.
> Perhaps this was a rounding issue, which we have fixed by using 64 bit
> intermediate variables ?

My point here is that this is a timecode, not a timestamp :) You need to use
the GstVideoTimeCode API for doing anything meaningful here, which would also
make any rounding issues disappear

(In reply to Aaron Boxer from comment #120)

> > Is a fixed framerate required, or can it be 0/1 or 0/0?
> 
> 
> Not sure if frame rate is fixed. What does 0/1 and 0/0 mean ?

0/0 is invalid in GStreamer, but would be what you set here if there is no
framerate provided by GStreamer. What does the spec say about this?

0/1 is GStreamer's way of saying "this is variable framerate". What does the
spec say about variable framerate?

Related to that, is the timecode box optional? Because timecodes make no sense
for variable framerate streams

> > 
> > @@ +842,3 @@
> > +          color_spec = 3;
> > +        } else {
> > +          color_spec = 1;       /* RGB as default */
> > 
> > What is it that is these values mean? Color range, primaries, matrix, gamma
> > transfer function, all at once? You might want to use
> > gst_video_colorimetry_from_string() and then look specifically at the struct
> > returned
> 
> I think the color spec indicates the colour space.

What does the spec say exactly for these values? You probably want color
primaries or the matrix here then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.