[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #24 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 356413:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=356413)

Looks good indeed, I only have one question below about locking. Is the other
patch obsolete now ?

::: sys/kms/gstkmssink.c
@@ +1293,3 @@
+
+  if (self->can_scale) {
+    gst_kms_sink_show_frame (GST_VIDEO_SINK (self), NULL);

Are you missing some locking here ? Normally show_frame() is called with stream
lock held, but now it's called from application thread, no locks. Have you
verified/protected everything inside that function ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.