[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #25 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #24)
> Review of attachment 356413 [details] [review]:
> 
> Looks good indeed, I only have one question below about locking. Is the
> other patch obsolete now ?

Old videooverlay interface patch has been obsolete. Then how about the check
scaleable patch, if not ok, then is there other better way for me to check this
feature? 

> 
> ::: sys/kms/gstkmssink.c
> @@ +1293,3 @@
> +
> +  if (self->can_scale) {
> +    gst_kms_sink_show_frame (GST_VIDEO_SINK (self), NULL);
> 
> Are you missing some locking here ? Normally show_frame() is called with
> stream lock held, but now it's called from application thread, no locks.
> Have you verified/protected everything inside that function ?

We have lock in show_frame function GST_OBJECT_LOCK (self).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.