[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

Haihua Hu <jared.hu at nxp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356483|none                        |reviewed
             status|                            |

--- Comment #38 from Haihua Hu <jared.hu at nxp.com> ---
Review of attachment 356483:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=356483)

::: sys/kms/gstkmssink.c
@@ +97,3 @@
+  GstKMSSink *self = GST_KMS_SINK (overlay);
+
+  if (width == 0 || height == 0)

We need add FIXME here if it should be fix later， and I think below is better

if (width <= 0 || height <= 0)
   return;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.