[Bug 784599] kmssink: support videooverlay interface
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jul 28 17:21:49 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=784599
--- Comment #39 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Haihua Hu from comment #38)
> Review of attachment 356483 [details] [review]:
>
> ::: sys/kms/gstkmssink.c
> @@ +97,3 @@
> + GstKMSSink *self = GST_KMS_SINK (overlay);
> +
> + if (width == 0 || height == 0)
>
> We need add FIXME here if it should be fix later, and I think below is better
There is no reason to merge an incomplete feature. It doesn't seem too complex
to get it done. Can you update the patch?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list