[Bug 783803] encoder: h264(AVC): Add multi reference support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783803

--- Comment #6 from Hyunjun Ko <zzoon at igalia.com> ---
Thanks for comment!

I choosed the A option since it's the simplest way.
I beleive that we can add something you mentioned about C option based on the
proposed patches.
These patches are a sort of RFC. So I need comments and review.

@Sree, IIUC, the commit below is worth to be merged. What do you think?
encoder: h264: Fix frame_num generation
(https://cgit.freedesktop.org/~sree/gstreamer-vaapi/commit/?h=advanced_enc&id=b3f9f31a4dc356e8ad6537477c5fc8b17a20d306)


(In reply to sreerenj from comment #2)
> (In reply to Hyunjun Ko from comment #1)
> 
> The question here is: How we interpret the number of future reference frames
> if there are B frames encoded. right?
> 
> A:
> The simple scenario is what you mentioned in \1.
> Option \2 will create confusion, So I won't prefer even though that is what
> intel-vaapi-driver is doing.
> 
> B:
> Look what x264enc is doing if we set "ref=n" and do the same with hw encoder.
> 
> c:
> Third option: You can add different algorithms and enable them based on a
> property. For eg: See how vaapivp9enc implemented the "ref-pic-mode". Here
> we can enable "multi-ref-b" as one of the options.
> You can take few patches from here I
> believe:https://cgit.freedesktop.org/~sree/gstreamer-vaapi/log/
> ?h=advanced_enc
> Specifically this one:
> https://cgit.freedesktop.org/~sree/gstreamer-vaapi/commit/
> ?h=advanced_enc&id=338e5d3a54f660acd628e4eeff336312c93bf0d8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.