[Bug 783803] encoder: h264(AVC): Add multi reference support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783803

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356499|none                        |reviewed
             status|                            |

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 356499:
 --> (https://bugzilla.gnome.org/review?bug=783803&attachment=356499)

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +1532,3 @@
+gboolean
+gst_vaapi_encoder_ensure_max_num_ref_frames (GstVaapiEncoder * encoder,
+    GstVaapiProfile profile, GstVaapiEntrypoint entrypoint)

Perhaps I'm missing something, but encoder has GstVaapiContext and it keeps the
profile and entrypoint, so there is no need to pass them.

::: gst-libs/gst/vaapi/gstvaapiencoder_priv.h
@@ +417,3 @@
     guint media_max_slices, guint * num_slices);

+G_GNUC_INTERNAL

I did the same mistake in gst_vaapi_encoder_ensure_num_slices() I shall fix it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.