[Bug 783086] vpxenc: memory usage grows when dropframe-threshold is enabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783086

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352566|none                        |needs-work
             status|                            |

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 352566:
 --> (https://bugzilla.gnome.org/review?bug=783086&attachment=352566)

::: ext/vpx/gstvpxenc.c
@@ +1697,3 @@
+        frame = gst_video_encoder_get_oldest_frame (video_encoder);
+      } while (expected_frame_number != 0 &&
+          frame->system_frame_number != expected_frame_number);

Interestingly, I have strong doubt that STATS packets replaces an encoded
frame. I'm starting to think that this code is totally wrong, that this block
should simply be removed.

@@ +1724,3 @@
+      frame = gst_video_encoder_get_oldest_frame (video_encoder);
+    } while (expected_frame_number != 0 &&
+        frame->system_frame_number != expected_frame_number);

I have my doubts about the correctness of using the frame number here. What VPX
seems to carry, is temporal information about the frames. It's unfortunate we
give the user control over the resolution, but yet, I think it still usable for
sorting out which frames are to be removed.

If you look attentively, the pkt contains a timestamp which is carried from the
input.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.