[Bug 783086] vpxenc: memory usage grows when dropframe-threshold is enabled

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 5 16:35:30 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783086

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Nicolas Dufresne (stormer) from comment #9)
> Review of attachment 352566 [details] [review]:
> 
> ::: ext/vpx/gstvpxenc.c
> @@ +1697,3 @@
> +        frame = gst_video_encoder_get_oldest_frame (video_encoder);
> +      } while (expected_frame_number != 0 &&
> +          frame->system_frame_number != expected_frame_number);
> 
> Interestingly, I have strong doubt that STATS packets replaces an encoded
> frame. I'm starting to think that this code is totally wrong, that this
> block should simply be removed.

Ignore this one, in first pass mode, only stats packets are produced. The fake
buffer is just to make the flow working and to prevent leaks that same way you
do now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list