[Bug 762509] vaapidecoder: h264: decoder stores too many pictures in the DPB before output

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762509

--- Comment #37 from Matt Staples <staples255 at gmail.com> ---
Review of attachment 353187:
 --> (https://bugzilla.gnome.org/review?bug=762509&attachment=353187)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +4966,3 @@
+      GstVaapiDecoderPropsH264 *propsh264 = (GstVaapiDecoderPropsH264 *)
+          props;
+

This doesn't support changes to properties after decoding starts.  If that's a
requirement, then decoder->priv could be modified to hold a reference to
propsh264 instead of simply copying the property value over here.

::: gst/vaapi/gstvaapidecode.c
@@ +985,3 @@
   g_mutex_clear (&decode->surface_ready_mutex);

+  gst_vaapi_decoder_props_replace (&decode->decoder_props, NULL);

This should be wrapped in "if (decoder->decoder_props)"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.