[Bug 783443] rtp: fix gst_rtp_buffer_ext_timestamp taking into account backwards

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 6 15:11:10 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783443

--- Comment #3 from Jose Antonio Santos Cadenas <santoscadenas at gmail.com> ---
Review of attachment 353198:
 --> (https://bugzilla.gnome.org/review?bug=783443&attachment=353198)

See comment in the code.

::: gst-libs/gst/rtp/gstrtpbuffer.c
@@ +1293,3 @@
+        /* timestamp went forwards more than allowed, we unwrap around and get
+         * updated extended timestamp. */
+        result += (G_GUINT64_CONSTANT (1) << 32);

We should check if we already did a wrap around before decreasing the 32 most
significative bits. Otherwise we'll be overflowing the value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list