[Bug 783443] rtp: fix gst_rtp_buffer_ext_timestamp taking into account backwards

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 6 15:22:38 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783443

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353197|none                        |needs-work
             status|                            |

--- Comment #4 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 353197:
 --> (https://bugzilla.gnome.org/review?bug=783443&attachment=353197)

This test should go into tests/check/libs/rtp.c

::: tests/check/generic/rtp.c
@@ +33,3 @@
+
+  gst_rtp_buffer_ext_timestamp (&ext_ts, 0);
+  fail_unless (ext_ts == 0x100000000);

Is this G_MAXUINT32 + 1 ? If so, please write is as such so it's a bit more
readable.

@@ +36,3 @@
+
+  gst_rtp_buffer_ext_timestamp (&ext_ts, 90000);
+  fail_unless (ext_ts == (0x100000000 + 90000));

Same here, I assume this is G_MAXUINT32 + 1 + 90000 ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list