[Bug 783443] rtp: fix gst_rtp_buffer_ext_timestamp taking into account backwards

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 6 15:24:15 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783443

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353198|none                        |needs-work
             status|                            |

--- Comment #5 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 353198:
 --> (https://bugzilla.gnome.org/review?bug=783443&attachment=353198)

::: gst-libs/gst/rtp/gstrtpbuffer.c
@@ +1293,3 @@
+        /* timestamp went forwards more than allowed, we unwrap around and get
+         * updated extended timestamp. */
+        result -= (G_GUINT64_CONSTANT (1) << 32);

I'm also not convinced that we shoudl ever make ext go backwards, which is the
result of this patch, as result is store into *ext in the end.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list