[Bug 783588] vaapidecoder: Add framework for codec-specific properties

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 15 14:10:19 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783588

--- Comment #10 from Matt Staples <staples255 at gmail.com> ---
Review of attachment 353754:
 --> (https://bugzilla.gnome.org/review?bug=783588&attachment=353754)

::: gst/vaapi/gstvaapidecode_props.c
@@ +49,3 @@
+  GstVaapiDecoderH264 *decoder =
+      GST_VAAPI_DECODER_H264 (GST_VAAPIDECODE (object)->decoder);
+

Wouldn't object->decoder be NULL here if this is called prior to starting the
pipeline (as happens when setting properties via gst-launch-1.0)?

That's why my previous patch included the new 'props' object - it provides a
way to get/set the values prior to the associated decoder object's creation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list