[Bug 783588] vaapidecoder: Add framework for codec-specific properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783588

--- Comment #11 from Matt Staples <staples255 at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #8)
> These patches are a Request For Comments:
> 
> What do you think?
> 
> IMO is much more simpler than any other approach, though it doesn't handle
> common properties, as done in the encoders, but I consider they are not
> required.

I like this organization.  It nicely separates the roles of get/vaapi and
get-libs/gst/vaapi.  

But see my review comments about the problems caused by the decoder object's
getting constructed later than the initial property get/set calls are made. 
(See gst_vaapidecode_reset and gst_vaapidecode_create in gstvaapidecode.c)

To that end, I like sreerenj's idea from comment #41 from bug 762509. It might 
require a bit of redesign, but the basic idea is that instead of delaying the
construction of decoder objects until caps are known, construct them earlier
and then 'activate' them once caps are known.  That way the decoder objects are
immediately available for property set/get, and we wouldn't need a separate
object for holding property values in the interim.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.