[Bug 783301] basesrc: Should not hold LIVE_LOCK when calling GstBaseSrcClass::create

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 28 22:46:29 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783301

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354154|none                        |accepted-commit_now
             status|                            |

--- Comment #11 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 354154:
 --> (https://bugzilla.gnome.org/review?bug=783301&attachment=354154)

Looks good!

::: libs/gst/base/gstbasesrc.c
@@ +255,2 @@
   /* QoS *//* with LOCK */
+  gboolean qos_enabled;         /* unused */

Should just remove qos_enabled as it's a private structure anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list