[Bug 783301] basesrc: Should not hold LIVE_LOCK when calling GstBaseSrcClass::create

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 29 14:38:32 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783301

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Olivier CrĂȘte from comment #11)
> Review of attachment 354154 [details] [review]:
> 
> Looks good!
> 
> ::: libs/gst/base/gstbasesrc.c
> @@ +255,2 @@
>    /* QoS *//* with LOCK */
> +  gboolean qos_enabled;         /* unused */
> 
> Should just remove qos_enabled as it's a private structure anyway.

Ah, thanks, I wanted to put that in a seperate patch, but forgot.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list