[Bug 774649] glupload: expose memory:DMABuf capsfeature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774649

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354577|none                        |reviewed
             status|                            |

--- Comment #8 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 354577:
 --> (https://bugzilla.gnome.org/review?bug=774649&attachment=354577)

Looks good.

::: gst-libs/gst/gl/gstglupload.c
@@ +530,3 @@
+    ret = gst_caps_merge (ret,
+        _set_caps_features_with_passthrough (caps,
+            GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY, passthrough));

The raw memory uploader will do this exact caps operation so adding these caps
are not really necessary and they will probably be folded in together so the
end result is extra work for no gain :).  I'm fine with either keeping or
removing it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.