[Bug 774649] glupload: expose memory:DMABuf capsfeature

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 30 07:34:25 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=774649

--- Comment #9 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Matthew Waters (ystreet00) from comment #8)
> Review of attachment 354577 [details] [review]:
> 
> Looks good.
> 
> ::: gst-libs/gst/gl/gstglupload.c
> @@ +530,3 @@
> +    ret = gst_caps_merge (ret,
> +        _set_caps_features_with_passthrough (caps,
> +            GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY, passthrough));
> 
> The raw memory uploader will do this exact caps operation so adding these
> caps are not really necessary and they will probably be folded in together
> so the end result is extra work for no gain :).  I'm fine with either
> keeping or removing it.

Indeed I verified and it works like you said. So I applied the change. Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list