[Bug 777847] ios/osx: Don't use manual reference counting in ObjC code

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777847

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347276|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347276:
 --> (https://bugzilla.gnome.org/review?bug=777847&attachment=347276)

Generally looks good but:

::: gst-libs/gst/gl/eagl/gstglwindow_eagl.m
@@ +164,2 @@
       callback (data);
+        gst_object_unref (context);

Wrong indentation

::: sys/applemedia/videotexturecache.m
@@ +145,3 @@
     CFRelease(data->texture);
     CFRelease(data->cache);
+    free(data);

Why do you revert this?

@@ +200,2 @@
 success: {
+  TextureWrapper *texture_data = malloc(sizeof(TextureWrapper));

And this?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.