[Bug 777847] ios/osx: Don't use manual reference counting in ObjC code

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777847

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347277|none                        |accepted-commit_now
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347277:
 --> (https://bugzilla.gnome.org/review?bug=777847&attachment=347277)

Looks good please provide another patch for:

::: ext/gl/caopengllayersink.m
@@ +330,3 @@
+
+   /* FIXME it appears that the layer is leaked in pre-ARC code;
+    * leaving its lifecycle unchanged for now. */

You can release it in READY->NULL in gst_ca_opengl_layer_sink_change_state().
You're right that it's leaked

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.