[Bug 779453] gst-player: fix gst-player failed to load external subtitle uri

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 8 07:52:38 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779453

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347444|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347444:
 --> (https://bugzilla.gnome.org/review?bug=779453&attachment=347444)

::: gst-libs/gst/player/gstplayer.c
@@ -586,3 @@
-  if (self->suburi) {
-    g_free (self->suburi);
-    self->suburi = NULL;

You're now not freeing self->suburi and not setting it to NULL. Apart from that
this looks good now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list