[Bug 779453] gst-player: fix gst-player failed to load external subtitle uri

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779453

--- Comment #10 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 347444 [details] [review]:
> 
> ::: gst-libs/gst/player/gstplayer.c
> @@ -586,3 @@
> -  if (self->suburi) {
> -    g_free (self->suburi);
> -    self->suburi = NULL;
> 
> You're now not freeing self->suburi and not setting it to NULL. Apart from
> that this looks good now

We cannot free and set self->suburi to NULL. Before start play, user may set
uri and suburi. After user call set_uri and set_suburi, the two operations will
not be conducted immediately. As a result, set_uri_internal will free suburi
which is user set at beginning and set_suburi_internal will set NULL to suburi
property.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.