[Bug 779765] GstUri: add function to parse uri and set properties to object

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779765

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347554|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 347554:
 --> (https://bugzilla.gnome.org/review?bug=779765&attachment=347554)

By default, g_object_set() will assert on bad values, bad ranges. This is not
acceptable from an URI. You need to pre-validate all the values, and their
ranges, so it can warn and fail cleanly.

::: gst/gsturi.h
@@ +251,3 @@
 const gchar * gst_uri_get_fragment     (const GstUri * uri);
 gboolean gst_uri_set_fragment          (GstUri * uri, const gchar * fragment);
+void gst_object_set_properties_from_uri_query_parameters (GObject *obj, const
GstUri *uri);

This is just way too long. One thing I notice, while reviewing, is that this is
way too generic. We need a way to filter certain properties to be binded.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.