[Bug 779765] GstUri: add function to parse uri and set properties to object

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779765

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #11)
> Review of attachment 347554 [details] [review]:
> 
> By default, g_object_set() will assert on bad values, bad ranges. This is
> not acceptable from an URI. You need to pre-validate all the values, and
> their ranges, so it can warn and fail cleanly.

Good catch, missed that above

> ::: gst/gsturi.h
> 
> This is just way too long.

Do you have any suggestions? I suggested this new name in comment 2 because the
previous one was just too generic. This function is doing something very
specific, unrelated to general URI semantics but adding a specific meaning on
top.

> One thing I notice, while reviewing, is that this
> is way too generic. We need a way to filter certain properties to be binded.

As you're the third to mention that, definitely ;) How about adding a parameter
of type "const gchar *filter[]" that is NULL terminated and contains property
names for this?

Also IMHO we also need a way for transforming the query parameters to their
respective types, i.e. a set of function pointers that do any custom conversion
(+ validation) when the default one does not apply.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.