[Bug 782118] qtdemux: Fix seeking on streams with frame reordering

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782118

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 350966:
 --> (https://bugzilla.gnome.org/review?bug=782118&attachment=350966)

Looks good to me. I only have nitpick kind of comments.

::: gst/isomp4/qtdemux.c
@@ +1175,3 @@
+  /* sample->timestamp is now <= media_time, need to find the corresponding
+   * PTS now by looking backwards */
+  while (index > 0 && sample->timestamp + sample->pts_offset > mov_time) {

Maybe some parenthesis for the reader ?

@@ +1180,3 @@
   }
+
+

Maybe just one empty line will do ?

@@ +4931,2 @@
     goto eos;
+  }

Maybe you can remove that part, it does not change anything.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.