[Bug 782118] qtdemux: Fix seeking on streams with frame reordering
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed May 3 15:45:07 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=782118
--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 350966:
--> (https://bugzilla.gnome.org/review?bug=782118&attachment=350966)
::: gst/isomp4/qtdemux.c
@@ +1163,3 @@
+ while (index < str->n_samples - 1) {
+ if (!qtdemux_parse_samples (qtdemux, str, index + 1))
+ goto parse_failed;
Actually, there is a possible corner case. If the position is passed that last
DTS, which happens when you seek to the last sample, it will reach
parse_failed. While it should pick the last sample as if it was searching
backward.
DTS: 0 1 2
PTS: 1 3 2
The algo works for seeking at 1 and 2, but not 3.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list