[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 11 16:55:44 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #39 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346550:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=346550)

::: gst-libs/gst/vaapi/gstvaapiencoder_priv.h
@@ +231,3 @@
+  /* Region of Interest */
+  gboolean got_roi_capability;
+  gboolean roi_capability;

I feel these two variables are not required at all. The roi_capability is
repeated in the GstVaapiConfigInfoEncoder, and got_roi_capability doesn't
change much, since the query is fast, there's no need of cache it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list