[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 11 16:57:27 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #40 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346552:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=346552)

::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +2270,3 @@
+    VAEncMiscParameterBufferROI *roi_param;
+    VAEncROI *region_roi, *region_ptr;
+    gint roi_num = g_list_length (base_encoder->roi_regions);

we are repeting twice the call g_list_length(), it would be better if we just
call it once, avoiding traversing the list for the same size.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list