[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #42 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 348978:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=348978)

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +1138,3 @@

+  if (encoder->roi_regions)
+    g_list_free (encoder->roi_regions);

here's a memory leak, since the allocated data are not freed.

@@ +1307,3 @@
+        region->rect.width == roi->rect.width &&
+        region->rect.height == roi->rect.height) {
+      encoder->roi_regions = g_list_remove (encoder->roi_regions, region);

here's a memory leak: we are not freeing the memory allocated for the
GstVaapiROO in _add_roi()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.