[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #41 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346553:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=346553)

::: tests/simple-encoder.c
@@ +34,3 @@
 static char **g_input_files = NULL;
+static guint g_roi_enable = 0;
+static GstVaapiROI *g_roi_region[2] = { NULL, };

There's no need to keep this global, it could bie in the App structure.

@@ +191,3 @@
+
+  for (i = 0; i < 2; i++) {
+    g_roi_region[i] = g_malloc0 (sizeof (GstVaapiROI));

we can save this malloc&free using normal array declared in App structure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.