[Bug 782337] jpeg2000parse: parse main level from j2k code stream and add to caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782337

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351746|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351746:
 --> (https://bugzilla.gnome.org/review?bug=782337&attachment=351746)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +74,3 @@
         GST_JPEG2000_SAMPLING_LIST ","
+        GST_JPEG2000_COLORSPACE_LIST ","
+        " capabilities = (int)[1, MAX]," " parsed = (boolean) true")

Do you *always* add it? And valid is [0, 65535] I guess, not [1, MAX] :)

@@ +369,3 @@
+    goto beach;
+
+  if (!gst_byte_reader_get_uint16_be (&reader, &capabilities))

What exactly does this integer contain? Would it make sense to split it into
multiple fields, or to attach it opaquely as a GstBuffer?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.