[Bug 782337] jpeg2000parse: parse main level from j2k code stream and add to caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782337

--- Comment #7 from Aaron Boxer <boxerab at gmail.com> ---
Thanks for the review.

(In reply to Sebastian Dröge (slomo) from comment #6)
> Review of attachment 351746 [details] [review]:
> 
> ::: gst/videoparsers/gstjpeg2000parse.c
> @@ +74,3 @@
>          GST_JPEG2000_SAMPLING_LIST ","
> +        GST_JPEG2000_COLORSPACE_LIST ","
> +        " capabilities = (int)[1, MAX]," " parsed = (boolean) true")
> 
> Do you *always* add it? And valid is [0, 65535] I guess, not [1, MAX] :)
> 

Yes, all J2K code streams must have this tag, so it makes sense to always add
it. And yes, should be [0, 65535] .


> @@ +369,3 @@
> +    goto beach;
> +
> +  if (!gst_byte_reader_get_uint16_be (&reader, &capabilities))
> 
> What exactly does this integer contain? Would it make sense to split it into
> multiple fields, or to attach it opaquely as a GstBuffer?

This integer contains two fields : JPEG 2000 profile (profile 0, profile 1,
broadcast, IMF)  and main level (a number from 0 to 11 that corresponds to
maximum bit rate). The logic for extracting the profile and main level varies
depending on what profile we are dealing with.

The MPEG TS muxer needs both fields to create a compliant stream.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.