[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352109|none                        |needs-work
             status|                            |

--- Comment #37 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 352109:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=352109)

Not quite there :)

::: ext/gl/gstgldownloadelement.c
@@ +97,3 @@
       "Downloads data from OpenGL", "Matthew Waters
<matthew at centricular.com>");
+
+  element_class->state_changed = gst_gl_download_element_state_changed;

This is typically done in change_state rather than state_changed.

@@ +417,3 @@
+
+  if (gst_query_find_allocation_meta (query, GST_VIDEO_META_API_TYPE, NULL))
+    download->add_videometa = TRUE;

And what about the failure case where on a reconfiguration, video meta is not
supported anymore?

@@ +432,3 @@
+    if (download->dmabuf_allocator) {
+      gst_object_unref (GST_OBJECT (download->dmabuf_allocator));
+      download->dmabuf_allocator = NULL;

This could also just as easily done in _finalize()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.