[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri May 26 18:45:59 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=776927

Matt Fischer <mattfischer84 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352109|needs-work                  |none
             status|                            |
 Attachment #352109|0                           |1
        is obsolete|                            |

--- Comment #38 from Matt Fischer <mattfischer84 at gmail.com> ---
Created attachment 352661
  --> https://bugzilla.gnome.org/attachment.cgi?id=352661&action=edit
Patch to add dmabuf export to gldownload

Here's a new version that addresses the comments from above.  I also had to add
a call to copy_metadata(), because without it the new buffer doesn't get the
right timestamps put on it.  That code was yanked from GstBaseTransform's
implementation of prepare_output_buffer(), which we don't get to here because
we override it and don't chain up.  In a perfect world, wouldn't we be doing
all of this in the transform function and not from prepare_output_buffer()?

In any case, this seems to work for me now.  Any further comments?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list