[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352676|none                        |needs-work
             status|                            |

--- Comment #48 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 352676:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=352676)

::: gst-libs/gst/gl/egl/gsteglimage.c
@@ +509,3 @@
+
+  if (!gst_eglExportDMABUFImageMESA (egl_display, image->image, fd, stride,
+          (EGLint *) offset))

Subtle, but very bad. I was testing with glupload to import the exported buffer
and it didn't work due to bad offset, and then just found this.

You are casting a gsize* to an int* here, on X86_64 that means a 64bit array to
a 32bit array. Only half of the gsize will be written in, leaving the rest as
random.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.