[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue May 30 18:19:43 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=776927

--- Comment #49 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 352676:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=352676)

::: ext/gl/gstgldownloadelement.c
@@ +315,3 @@
+
+    if (info) {
+      offset[i] = info->offset;

There is another bug here, the offset is from the start of the DMABuf, while
the info->offset refer to the offset in the GstBuffer. To create a valid
GstBuffer offset, you need the previous offset + previous memory size +
info->offset.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list