[Bug 790167] concat: Handle single-pad use-cases

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790167

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #363343|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 363343:
 --> (https://bugzilla.gnome.org/review?bug=790167&attachment=363343)

I think this makes sense, re-reading some of my code, I notice that I simply
remove the concat and create a new one if it reached that state. Being able to
flush or seek it seems rather useful.

::: plugins/elements/gstconcat.c
@@ +398,3 @@
+    if (self->current_sinkpad == NULL && g_list_length (self->sinkpads) == 1)
{
+      GST_LOG_OBJECT (spad, "Sole pad waiting, switching");
+      /* If we are the only sinkpad, take active pad ownership */

Maybe "If there is only one sinkpad, ..."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.