[Bug 790167] concat: Handle single-pad use-cases

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 10 15:56:45 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790167

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #363343|accepted-commit_now         |committed
             status|                            |

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
Comment on attachment 363343
  --> https://bugzilla.gnome.org/attachment.cgi?id=363343
concat: Handle single-pad use-cases

commit f03443f90c6d5d143861f5e75990d06b700a5895 (HEAD -> master, origin/master,
origin/HEAD)
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Fri Nov 10 14:10:31 2017 +0100

    concat: Handle single-pad use-cases

    When EOS reaches concat, it will switch to the next candidate as its
    activate pad.

    The problem arises when there is only one sinkpad, the "active" pad
    becomes NULL. This results in concat becoming unusable after it receives
    a *single* EOS on its single sinkpad.

    If we detect there is a single sinkpad and there is no current active pad:
    * If we are waiting (from selected sink event/buffer), become the current
      active pad.
    * If there is a seek request, send it upstream. We don't switch the
      active_sinkpad property at that point in time, since the seek could
      fail. If the seek succeeds, the following SEGMENT (or STREAM_START)
      will cause the pad_wait() to elect that pad as the new active one.
    * Flush events get forwarded

    https://bugzilla.gnome.org/show_bug.cgi?id=790167

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list