[Bug 790312] msdk: memory leak always happen when using encoder.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790312

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #363555|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 363555:
 --> (https://bugzilla.gnome.org/review?bug=790312&attachment=363555)

Looks good but:

::: sys/msdk/gstmsdkenc.c
@@ +527,3 @@
+    GST_INFO_OBJECT (thiz,
+        "No sync point from the driver, skipping this frame");
+    goto fail;

This is no "fail" really, it's somewhat expected behaviour. Maybe call the
label "out", "done", or similar?

Also why would it give no sync point? And will the frame appear decoded at a
later time, or is it literally gone?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.