[Bug 790312] msdk: memory leak always happen when using encoder.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790312

--- Comment #3 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 363555 [details] [review]:
> 
> Looks good but:
> 
> ::: sys/msdk/gstmsdkenc.c
> @@ +527,3 @@
> +    GST_INFO_OBJECT (thiz,
> +        "No sync point from the driver, skipping this frame");
> +    goto fail;
> 
> This is no "fail" really, it's somewhat expected behaviour. Maybe call the
> label "out", "done", or similar?

That's what I hesitated actually. Probably 'done' would be better.

> 
> Also why would it give no sync point? And will the frame appear decoded at a
> later time, or is it literally gone?

Well, I realized that I misunderstood the situation :(
In this case, the driver returns MORE_DATA, which means that the frame will be
decoded later.
And this patch is wrong!

I'll re-propose a patch to handle MORE_DATA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.