[Bug 790793] CineForm plugin for GStreamer bad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790793

--- Comment #6 from emeric.grange at gmail.com ---
+ I would just call the directory cineform, shorter and the SDK part does not
really add anything.
You mean for the plugin name & directory? I though we might see another
implementation someday, not using this SDK. But I really don't mind if you
prefer without the SDK ^^

No problem I'll fix the C99 comments, the cineform_allocator and remove most of
the leftover debug code from cineform_debug.c and some ENABLE_STATS.

Regarding "Decoding format", you can force a pixel format. But yeah this is
probably not something useful to expose in the context of GStreamer, I'll
remove it.

"Decoding size" is actually fun, because CineForm is a wavelet codec, you can
ask a decode at full, half or quarter resolution.

+ Should the stereo things be taken from the caps instead maybe?
Definitely.

+ This should probably get an enum and become an enum property? Does the format
have to be part of the caps, i.e. should it be negotiated?
While the format could be negotiated I still think the user should choose what
he wants.

+ Do you need just memory or is memory wrapped in something else possible?
Just memory.

+ This would mean that your encode can handle *any* rowstride, plane padding,
etc.
+ Can it? You need to get it from the GstVideoFrame for each frame
I don't think it can.

I don't remember why I was not encoding directly in memory, because that's the
only case where I could actually handle two pixel formats without extra manual
conversion. I'll have another take at it.

I'll work on all that and get back to you, thanks for the review!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.