[Bug 790793] CineForm plugin for GStreamer bad

Sat Nov 25 12:58:45 UTC 2017

https://bugzilla.gnome.org/show_bug.cgi?id=790793

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunier at gnome.org

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
I tried that patchset to benchmark perfs/how it works for the potential use of
CineForm as possible proxy format in the Pitivi Video Editor, but I can not
build your patchset right now.

First I needed https://github.com/gopro/cineform-sdk/pull/21 to package for
arch and then building fails:

```
ninja: Entering directory `/home/thiblahute/devel/gstreamer/gst-build/build'
[15/377] Compiling C object
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/cineform_debug.c.o'.
FAILED:
subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/cineform_debug.c.o 
ccache cc  -Isubprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha
-Isubprojects/gst-plugins-bad/ext/cineformsdk
-I../subprojects/gst-plugins-bad/ext/cineformsdk -Isubprojects/gst-plugins-bad
-I../subprojects/gst-plugins-bad -Isubprojects/gst-plugins-base/gst-libs
-I../subprojects/gst-plugins-base/gst-libs -Isubprojects/gstreamer/libs
-I../subprojects/gstreamer/libs -Isubprojects/gstreamer
-I../subprojects/gstreamer -Isubprojects/gst-plugins-base/gst-libs/gst/video
-Isubprojects/gstreamer/libs/gst/base -Isubprojects/gstreamer/gst
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orc-0.4
-I/usr/include/cineformsdk -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O0 -g -fvisibility=hidden
-fPIC -pthread -DHAVE_CONFIG_H -MMD -MQ
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/cineform_debug.c.o'
-MF
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/cineform_debug.c.o.d'
-o
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/cineform_debug.c.o'
-c ../subprojects/gst-plugins-bad/ext/cineformsdk/cineform_debug.c
../subprojects/gst-plugins-bad/ext/cineformsdk/cineform_debug.c: In function
‘printEncodedFormats’:
../subprojects/gst-plugins-bad/ext/cineformsdk/cineform_debug.c:174:5: error:
enumeration value ‘CFHD_ENCODED_FORMAT_UNKNOWN’ not handled in switch
[-Werror=switch]
     switch (format)
     ^~~~~~
cc1: all warnings being treated as errors
[22/377] Compiling C object
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformsdk.c.o'.
FAILED:
subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformsdk.c.o 
ccache cc  -Isubprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha
-Isubprojects/gst-plugins-bad/ext/cineformsdk
-I../subprojects/gst-plugins-bad/ext/cineformsdk -Isubprojects/gst-plugins-bad
-I../subprojects/gst-plugins-bad -Isubprojects/gst-plugins-base/gst-libs
-I../subprojects/gst-plugins-base/gst-libs -Isubprojects/gstreamer/libs
-I../subprojects/gstreamer/libs -Isubprojects/gstreamer
-I../subprojects/gstreamer -Isubprojects/gst-plugins-base/gst-libs/gst/video
-Isubprojects/gstreamer/libs/gst/base -Isubprojects/gstreamer/gst
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orc-0.4
-I/usr/include/cineformsdk -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O0 -g -fvisibility=hidden
-fPIC -pthread -DHAVE_CONFIG_H -MMD -MQ
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformsdk.c.o'
-MF
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformsdk.c.o.d'
-o
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformsdk.c.o'
-c ../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk.c
In file included from
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformenc.h:30:0,
                 from
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk.c:27:
/usr/include/cineformsdk/CFHDEncoder.h:322:6: error: unknown type name ‘bool’;
did you mean ‘_Bool’?
      bool temporary);
      ^~~~
      _Bool
[23/377] Compiling C object
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformenc.c.o'.
FAILED:
subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformenc.c.o 
ccache cc  -Isubprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha
-Isubprojects/gst-plugins-bad/ext/cineformsdk
-I../subprojects/gst-plugins-bad/ext/cineformsdk -Isubprojects/gst-plugins-bad
-I../subprojects/gst-plugins-bad -Isubprojects/gst-plugins-base/gst-libs
-I../subprojects/gst-plugins-base/gst-libs -Isubprojects/gstreamer/libs
-I../subprojects/gstreamer/libs -Isubprojects/gstreamer
-I../subprojects/gstreamer -Isubprojects/gst-plugins-base/gst-libs/gst/video
-Isubprojects/gstreamer/libs/gst/base -Isubprojects/gstreamer/gst
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orc-0.4
-I/usr/include/cineformsdk -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O0 -g -fvisibility=hidden
-fPIC -pthread -DHAVE_CONFIG_H -MMD -MQ
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformenc.c.o'
-MF
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformenc.c.o.d'
-o
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformenc.c.o'
-c ../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformenc.c
In file included from
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformenc.h:30:0,
                 from
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformenc.c:34:
/usr/include/cineformsdk/CFHDEncoder.h:322:6: error: unknown type name ‘bool’;
did you mean ‘_Bool’?
      bool temporary);
      ^~~~
      _Bool
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformenc.c:459:1: error:
‘gst_cfhd_enc_propose_allocation’ defined but not used
[-Werror=unused-function]
 gst_cfhd_enc_propose_allocation (GstVideoEncoder * encoder, GstQuery * query)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
[24/377] Compiling C object
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformdec.c.o'.
FAILED:
subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformdec.c.o 
ccache cc  -Isubprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha
-Isubprojects/gst-plugins-bad/ext/cineformsdk
-I../subprojects/gst-plugins-bad/ext/cineformsdk -Isubprojects/gst-plugins-bad
-I../subprojects/gst-plugins-bad -Isubprojects/gst-plugins-base/gst-libs
-I../subprojects/gst-plugins-base/gst-libs -Isubprojects/gstreamer/libs
-I../subprojects/gstreamer/libs -Isubprojects/gstreamer
-I../subprojects/gstreamer -Isubprojects/gst-plugins-base/gst-libs/gst/video
-Isubprojects/gstreamer/libs/gst/base -Isubprojects/gstreamer/gst
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orc-0.4
-I/usr/include/cineformsdk -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O0 -g -fvisibility=hidden
-fPIC -pthread -DHAVE_CONFIG_H -MMD -MQ
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformdec.c.o'
-MF
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformdec.c.o.d'
-o
'subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformsdk at sha/gstcineformdec.c.o'
-c ../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c: In function
‘gst_cfhd_dec_class_init’:
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:143:72: error:
multi-character character constant [-Werror=multichar]
                                                         0, 0xFFFFFFFF,
DEFAULT_DECODING_FORMAT,

^~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c: In function
‘gst_cfhd_dec_init’:
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:234:49: error:
multi-character character constant [-Werror=multichar]
     gst_cfhd_dec->decFormat = (CFHD_PixelFormat)DEFAULT_DECODING_FORMAT;
                                                 ^~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c: In function
‘gst_cfhd_dec_image_to_buffer’:
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:430:9: error:
unused variable ‘width’ [-Werror=unused-variable]
     int width = GST_VIDEO_FRAME_COMP_WIDTH (&vframe, 0);
         ^~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:428:11: error:
unused variable ‘pixel_stride’ [-Werror=unused-variable]
     guint pixel_stride = GST_VIDEO_FRAME_COMP_PSTRIDE (&vframe, 0);
           ^~~~~~~~~~~~
In file included from ../subprojects/gstreamer/gst/gst.h:55:0,
                 from
../subprojects/gst-plugins-base/gst-libs/gst/video/video.h:23,
                 from
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:29:
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c: In function
‘gst_cfhd_dec_handle_frame’:
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:458:14: error:
format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 8
has type ‘uint64_t {aka long unsigned int}’ [-Werror=format=]
     GST_INFO("-------- gst_cfhd_dec_handle_frame()   --   #%llu",
gst_cfhd_dec->sampleDecoded);
              ^                                                   
~~~~~~~~~~~~~~~
../subprojects/gstreamer/gst/gstinfo.h:640:31: note: in definition of macro
‘GST_CAT_LEVEL_LOG’
         (GObject *) (object), __VA_ARGS__);    \
                               ^~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:458:5: note: in
expansion of macro ‘GST_INFO’
     GST_INFO("-------- gst_cfhd_dec_handle_frame()   --   #%llu",
gst_cfhd_dec->sampleDecoded);
     ^~~~~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:455:22: error:
unused variable ‘gst_cfhd_dec_class’ [-Werror=unused-variable]
     GstCFHDDecClass *gst_cfhd_dec_class = GST_CFHD_DEC_GET_CLASS
(gst_cfhd_dec);
                      ^~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/cineformsdk/gstcineformdec.c:450:10: error:
variable ‘decoder_deadline’ set but not used [-Werror=unused-but-set-variable]
     long decoder_deadline = 0;
          ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.
```

Almost same issues with autotools.

Looks like the headers use some C++ features (bool) but we build as pure C - I
tried forcing to build as C++ but I get a new issues doing that :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.