[Bug 788758] vaapidecodebin: Register element if no VPP support is available too

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788758

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361216|none                        |needs-work
             status|                            |

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 361216:
 --> (https://bugzilla.gnome.org/review?bug=788758&attachment=361216)

::: gst/vaapi/gstvaapidecodebin.c
@@ +314,3 @@
+  } else {
+    GST_INFO_OBJECT (vaapidecbin, "Creating a dummy display to test for vpp");
+    display = gst_vaapi_create_test_display ();

I'm a bit worry of creating, again, a test display to check if vpp is
supported. I foresee three options:

1\ pass has_vpp to the element at registration time
2\ query for display through the gst context mechanism
3\ ignore all that and just create a test display again 

The first option looks promising

The second would mean to get vaapidecodebin more complex than needed

The third option is simpler, cleaner in code terms, but expensive.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.