[Bug 788758] vaapidecodebin: Register element if no VPP support is available too

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788758

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Víctor Manuel Jáquez Leal from comment #2)
> Review of attachment 361216 [details] [review]:
> 
> ::: gst/vaapi/gstvaapidecodebin.c
> @@ +314,3 @@
> +  } else {
> +    GST_INFO_OBJECT (vaapidecbin, "Creating a dummy display to test for
> vpp");
> +    display = gst_vaapi_create_test_display ();
> 
> I'm a bit worry of creating, again, a test display to check if vpp is
> supported. I foresee three options:
> 
> 1\ pass has_vpp to the element at registration time

>From the code that registers vaapidecodebin you mean? There's no easy way to
pass this information through to the element, other than a global variable.

We could check once in gstvaapi.c if VPP is supported with the test display,
and then just remember that. Would that work for you? E.g. by allowing to pass
NULL to gst_vaapi_display_has_video_processing() or adding a new function or
global variable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.