[Bug 788918] vaapi: supports hierarchical prediction encoding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788918

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361490|none                        |needs-work
             status|                            |

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 361490:
 --> (https://bugzilla.gnome.org/review?bug=788918&attachment=361490)

::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +114,3 @@
+  GST_VAAPI_ENCODER_H264_PREDICTION_DEFAULT = 0,
+  GST_VAAPI_ENCODER_H264_PREDICTION_HIERARCHICAL_P = 1,
+  GST_VAAPI_ENCODER_H264_PREDICTION_HIERARCHICAL_B = 2

AFAIU in this case there is no need to set a manual value to the enums, since
that is the default

@@ +132,3 @@
+      {GST_VAAPI_ENCODER_H264_PREDICTION_HIERARCHICAL_B,
+            "Hierarchical B frame encode",
+          "hierarchical-b"}

The GEnumValue array must be terminated by a struct with all members being 0. 

{0, NULL, NULL},

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.