[Bug 788918] vaapi: supports hierarchical prediction encoding

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Oct 19 13:53:08 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=788918

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361492|none                        |reviewed
             status|                            |

--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 361492:
 --> (https://bugzilla.gnome.org/review?bug=788918&attachment=361492)

::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +2852,3 @@
+    reorder_pool->prev_frame_is_ref = TRUE;
+  else
+    reorder_pool->prev_frame_is_ref = FALSE;

this would be simpler as

reorder_pool->prev_frame_is_ref = GST_VAAPI_ENC_PICTURE_IS_REFRENCE (picture);

or even better

reorder_pool->prev_frame_is_ref = GST_VAAPI_ENC_PICTURE_IS_REFRENCE (picture)
|| GST_VAAPI_ENC_PICTURE_IS_IDR (picture);

removing the up assignation

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list