[Bug 787466] glimagesink: release buffers on GST_EVENT_FLUSH_START

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Sep 10 00:18:12 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=787466

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359427|none                        |rejected
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359427:
 --> (https://bugzilla.gnome.org/review?bug=787466&attachment=359427)

That code is wrong, because if gst_video_overlay_expose() is called during a
seek, you'll now get a visual glitch.

::: ext/gl/gstglimagesink.c
@@ +1078,3 @@
+        gl_sink->stored_sync = NULL;
+
+    //  GST_GLIMAGE_SINK_UNLOCK (gl_sink);

C++ comment, useless line.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list